Enable start line and column for Zed only #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dug deeper into the issue (and the Onlook codebase) because the supposed URL from OnLook was working fine for me, but I didn't realise it was adding end row and column info to pinpoint the core issue. So the initally linked issue isn't the same as what I'm facing. I created zed-industries/zed#18520 with more details if you're interested. P.S. Sorry for the noise: I should've looked into the Onlook codebase before posting here. |
|
Thanks for following up! |
Kitenite
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-enables the Zed integration by addressing a specific edge case: it only appends the start line and column to the URL when the URL is specifically for Zed and not the end line and column (see zed-industries/zed#18520 for more info)
Closes #415
What is the purpose of this pull request?