Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom header level icons #526

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

abhiroopc84
Copy link
Contributor

@abhiroopc84 abhiroopc84 commented Oct 14, 2024

Description

Adds custom icons for header levels so that we don't have to rely on plain written text to demonstrate to a user what level header they have selected and the pilcrow icon for paragraph tag.

Issue #465

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@Kitenite Kitenite requested a review from drfarrell October 14, 2024 18:37
Copy link
Collaborator

@drfarrell drfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid thanks for putting it together. One thing I'm interested to know is if the muted H on the icon will show up well on light mode – seeing that this is a branch that isn't built with the light mode, can you test it out and show what that looks like @abhiroopc84? I'm sure it'll be fine but just want to see if the icons get lost in the lightmode color scheme.

@Kitenite
Copy link
Contributor

This is a very good solution for the light mode adaptations
#534

@hitaspdotnet
Copy link
Contributor

This is a very good solution for the light mode adaptations #534

we should not face such problems because of light mode. we already have required tokens which works in dark & light.

we can put all icons/logos/svg in one place ex: components/icons.tsx.
usage: <Icons.Logo className="w-24 fill-foreground" />

@Kitenite
Copy link
Contributor

Merged main for light mode testing

@drfarrell
Copy link
Collaborator

@abhiroopc84

The icons aren't showing up in light mode –
image

image

Perhaps if you try @hitaspdotnet 's recommendation it will solve it and then we can close it out 👍
image

@abhiroopc84
Copy link
Contributor Author

Okay, I'll add a component for all the icons, so we can style them

@abhiroopc84 abhiroopc84 requested a review from drfarrell October 17, 2024 19:02
@abhiroopc84
Copy link
Contributor Author

@drfarrell I've fixed the coloring for active state. Could you review the changes?

@Kitenite Kitenite self-requested a review October 18, 2024 12:57
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice work!

@Kitenite Kitenite removed the request for review from drfarrell October 18, 2024 13:01
@Kitenite Kitenite merged commit 2619463 into onlook-dev:main Oct 18, 2024
@Kitenite Kitenite linked an issue Oct 18, 2024 that may be closed by this pull request
@abhiroopc84 abhiroopc84 deleted the feat/custom-layer-header-icons branch October 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Custom Header Icons in the layers panel
4 participants