-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom header level icons #526
Add custom header level icons #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid thanks for putting it together. One thing I'm interested to know is if the muted H on the icon will show up well on light mode – seeing that this is a branch that isn't built with the light mode, can you test it out and show what that looks like @abhiroopc84? I'm sure it'll be fine but just want to see if the icons get lost in the lightmode color scheme.
This is a very good solution for the light mode adaptations |
we should not face such problems because of light mode. we already have required tokens which works in dark & light. we can put all icons/logos/svg in one place ex: |
Merged main for light mode testing |
The icons aren't showing up in light mode – Perhaps if you try @hitaspdotnet 's recommendation it will solve it and then we can close it out 👍 |
Okay, I'll add a component for all the icons, so we can style them |
…bhiroopc84/onlook into feat/custom-layer-header-icons
@drfarrell I've fixed the coloring for active state. Could you review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice work!
Description
Adds custom icons for header levels so that we don't have to rely on plain written text to demonstrate to a user what level header they have selected and the pilcrow icon for paragraph tag.
Issue #465
What is the purpose of this pull request?