Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Youtube link during Setup #576

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

aPassie
Copy link
Contributor

@aPassie aPassie commented Oct 17, 2024

Add in a button that navigates the user to https://youtu.be/RjFBUkVfy1E?t=45&feature=shared in their browser

@Kitenite Kitenite requested a review from drfarrell October 17, 2024 21:25
Copy link
Collaborator

@drfarrell drfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a few small things to make it feel more on-brand.

The classes need to comply with our tailwind classes so it shows up correctly in lightmode. This should be easy, use classes like – bg-background-onlook or bg-foreground for example.
image

The entire button should be clickable, not just the link. It should hover similarly to the "Click to select folder" button.

The typography should use text-RegularPlus class for the title and text-Regular class for the a text, just so we keep it within our typography system.

The Icons we use are Radix icons. Please swap the external link icon from lucide to radix – you can just add in the icon into the radix import at the top.

Let's make the dimensions of the photo the correct dimensions so it fits nicely without the top and bottom black bars.

We handle opening external links a little differently than what was proposed... try following what we did for the signin page
Screenshot 2024-10-17 at 5 35 39 PM

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Add a link to a YouTube tutorial to help people run a project during project setup
3 participants