-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom color picker #609
Custom color picker #609
Conversation
I put in a number of style changes to the color-picker to generally tighten the UI and make it feel more on-brand. A couple of larger comments. 1. HEX code values are generally preferred vs RGB and HSL – we'll need to accommodate the different input styles here like how Figma does. That probably means using a different input style depending on how many inputs you need. Some examples: 2. Style generator feature I'm not sure if @hitaspdotnet you were planning on using the color spectrum generator in the lower left corner or what your plans were for that, but I think the goal with having the tokens below the custom color-picker would be to make it easy for the user to select from a pre-defined palette, more-so than use the color picker to define that palette on the right side. I know we're still working on this, just writing it down in case you had a plan. The goal for the color swatches below the custom color picker would be for them to be the available global-level Tailwind tokens from the codebase. 3. Token name in color input This can be a separate PR if we'd like. |
…nlook into feat/color-picker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! Baller
Description
Custom Color Picker
What is the purpose of this pull request?