Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom color picker #609

Merged
merged 37 commits into from
Oct 22, 2024
Merged

Conversation

hitaspdotnet
Copy link
Contributor

Description

Custom Color Picker

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@Kitenite Kitenite self-requested a review October 19, 2024 14:02
@Kitenite Kitenite mentioned this pull request Oct 19, 2024
6 tasks
@hitaspdotnet hitaspdotnet marked this pull request as ready for review October 20, 2024 15:24
@drfarrell
Copy link
Collaborator

I put in a number of style changes to the color-picker to generally tighten the UI and make it feel more on-brand.

A couple of larger comments.

1. HEX code values are generally preferred vs RGB and HSL – we'll need to accommodate the different input styles here like how Figma does. That probably means using a different input style depending on how many inputs you need. Some examples:

image image

2. Style generator feature
It seems like when you select an element, you also render a 50-950 color spread (very cool) which is useful for generating palettes, but perhaps not for being able to select colors along the 50-950 spectrum as fixed values.

I'm not sure if @hitaspdotnet you were planning on using the color spectrum generator in the lower left corner or what your plans were for that, but I think the goal with having the tokens below the custom color-picker would be to make it easy for the user to select from a pre-defined palette, more-so than use the color picker to define that palette on the right side. I know we're still working on this, just writing it down in case you had a plan.

The goal for the color swatches below the custom color picker would be for them to be the available global-level Tailwind tokens from the codebase.

image

3. Token name in color input
When a token is selected, it would be nice to use that token-name in the color input on the properties panel, not necessarily the hard-coded value if it isn't custom.
image

This can be a separate PR if we'd like.

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! Baller

@Kitenite Kitenite merged commit 1eeceb1 into onlook-dev:main Oct 22, 2024
@hitaspdotnet hitaspdotnet deleted the feat/color-picker branch October 22, 2024 20:57
@Kitenite Kitenite linked an issue Oct 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Custom Color Picker
3 participants