Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximize on windows and modify styles #611

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

abhiroopc84
Copy link
Contributor

Description

Modified the color of the close button to red on hover and active states, the shape of the buttons to fill the div, also the icon for maximize button. I also added in the unmaximize functionality to the maximize button, which was missing before.

old.mp4
vlc-record-2024-10-19-21h40m45s-recording.avi-.mp4
Untitled.video.-.Made.with.Clipchamp.42.mp4

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in testing! Thanks for implementing this :)

@Kitenite Kitenite merged commit 1e6eef2 into onlook-dev:main Oct 19, 2024
@abhiroopc84 abhiroopc84 deleted the bugs/fix-maximize-windows branch October 19, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants