Fix dom not ready crashing the app

[abhiroopc84]

Description

Fix an issue where the app was crashing when an element tries to call a method that requires the dom-ready event to be emitted before.

What is the purpose of this pull request?

• New feature
• Documentation update
• Bug fix
• Refactor
• Release
• Other

[Kitenite]

I don't think this would be the case. The reference itself is non-null. The instance it references may be null. But it seems more of an issue due to the electron webview instance not loading a DOM yet. Has #612 failed to fix the issue?

[abhiroopc84]

#612 did fix the issue, but I just thought adding two additional try catch blocks just to catch those errors would be redundant when we can just have a state domReady that is a boolean value which we'll use to either pass the webviewRef when dom has loaded, or null when dom hasn't loaded yet, to the BrowserControl component. domReady state can be set to true when we run the existing handleDomReady function. This way we'll be fixing the issue in the same component where the webviewRef is defined originally, so we can always use the same fix even if we face a similar error in some other component instead of adding try catch blocks in each such error component.

[Kitenite]

I like this. It adds just a bit of complexity but it's better than my duct tape solution. Well done!

[Kitenite]

Ah I see what you did. Apologies, I missed this. This makes sense and adds a level of security. I'd hate to have an error thrown needlessly.