Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanding UI #623

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Sanding UI #623

merged 3 commits into from
Oct 22, 2024

Conversation

drfarrell
Copy link
Collaborator

Description

Tons of small style improvements, primarily to the browser window.

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@drfarrell
Copy link
Collaborator Author

I know I introduced the tablet icon and didn't actually implement it – I was having some issues with getting it imported into the responsive window dropdown, but figured someone may be able to get the custom .svg icon in.

@drfarrell drfarrell requested a review from Kitenite October 22, 2024 16:26
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge!

@@ -36,7 +36,10 @@ const AppBar = observer(() => {
<Button
size="sm"
variant="ghost"
className={clsx(updateManager.updateAvailable && 'hover:bg-red-800')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making a new button variant for red buttons?

@Kitenite Kitenite merged commit b3c12ce into main Oct 22, 2024
@Kitenite Kitenite deleted the Sanding-ui branch October 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants