Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggle the eye open and close, hover to show #626

Merged
merged 8 commits into from
Oct 27, 2024
Merged

toggle the eye open and close, hover to show #626

merged 8 commits into from
Oct 27, 2024

Conversation

RaghavGanesh7
Copy link
Contributor

Description

  • [feat] "Hide" or "Show" Eyeball icon on the layers list #364
  • Added Eyeopen and eyeclosed icons in the panel tab which visible on hover.
  • Toggle the tree to close when the parent is hidden and also hidden elements should have grey text
  • Added visibility property to LayerNode which can be accessed in the future implementation of remaining feature.

What is the purpose of this pull request?

Kitenite
Kitenite reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Could you enable pushing to this branch so I can add the functionalities before merging?

Kitenite
Kitenite requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna put this in change requested state for now since I can't merge this as is :)

@Kitenite Kitenite self-requested a review October 27, 2024 14:43
Kitenite
Kitenite approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for updating quickly on feedback :)

@Kitenite Kitenite merged commit 8186e84 into onlook-dev:main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kitenite Kitenite Kitenite approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaghavGanesh7 @Kitenite