Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared tsconfig #694

Merged
merged 3 commits into from
Oct 31, 2024
Merged

shared tsconfig #694

merged 3 commits into from
Oct 31, 2024

Conversation

hitaspdotnet
Copy link
Contributor

Description

Shared TS configs for bun compiler

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@hitaspdotnet hitaspdotnet mentioned this pull request Oct 31, 2024
6 tasks
@Kitenite
Copy link
Contributor

Hanging on bun run build at root for me. Hanging really at @onlook/studio

❯ bun run build
$ bun --filter '*' build
@onlook/foundation build $ tsup
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ CLI Building entry: src/index.ts
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [1 lines elided]
│ CLI Using tsconfig: tsconfig.json
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [2 lines elided]
│ CLI tsup v8.3.5
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [3 lines elided]
│ CLI Using tsup config: /Users/kietho/workplace/onlook/onlook/packages/foundation/tsup.config.ts
│ CLI Target: esnext
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [5 lines elided]
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
│ DTS dist/index.d.mts 1.08 KB
│ DTS dist/index.d.ts  1.08 KB
└─ Running...
onlook build $ esbuild src/index.ts --bundle --platform=node --forma
@onlook/foundation build $ tsup
│ [5 lines elided]
│ ESM Build start
│ CJS Build start
│ CJS dist/index.js 227.21 KB
│ CJS ⚡️ Build success in 33ms
│ ESM dist/index.mjs 225.56 KB
│ ESM ⚡️ Build success in 34ms
│ DTS Build start
│ DTS ⚡️ Build success in 966ms
│ DTS dist/index.d.mts 1.08 KB
│ DTS dist/index.d.ts  1.08 KB
└─ Done in 1.33 s
onlook build $ esbuild src/index.ts --bundle --platform=node --format=cjs --outfile=dist/index.cjs
│ 
│   dist/index.cjs  2.4mb ⚠️
│ 
│ ⚡ Done in 35ms
└─ Done in 42 ms
@onlook/studio build $ tsc && vite build
└─ Running...

@Kitenite
Copy link
Contributor

Looks like the vite command is what is hanging. Same with bun run dev. Potentially is failing silently.
bun run clean before didn't help.

@Kitenite Kitenite merged commit 3ca5489 into onlook-dev:main Oct 31, 2024
@Kitenite
Copy link
Contributor

The build issue stemmed from .js files being generated (not sure when that happened). Stashing those files and building worked. No regressions found.

@hitaspdotnet hitaspdotnet deleted the packages/typescript branch October 31, 2024 19:25
@hitaspdotnet hitaspdotnet restored the packages/typescript branch November 1, 2024 10:42
@hitaspdotnet hitaspdotnet deleted the packages/typescript branch November 1, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants