feat: handle drag the broweser canvas #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitenite
reviewed
Nov 3, 2024
| const transform = window.getComputedStyle(element).transform; | ||
| const matrix = new DOMMatrix(transform); | ||
|
|
||
| top += matrix.m42; |
There was a problem hiding this comment.
Just curious what does this do? Seems like it's taking into account the transform better than before but why are you parsing into a matrix?
There was a problem hiding this comment.
To obtain the web frame's position, we should use getComputedStyle to retrieve the transform values, which cannot be obtained by offset properties. Since the values are presented in matrix format, I utilized the DOMMatrix class for easier manipulation.
There was a problem hiding this comment.
Gotcha, I learned something new today. Thanks!
Kitenite
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #619
Description
Ability for a user to select the top of the browser controls and drag the selected window around the infinite canvas.
Screen.Recording.2024-11-02.at.16.44.36.mov
What is the purpose of this pull request?