Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Logic For Adding Conditional Dynamic Type #877

Merged
merged 22 commits into from
Dec 11, 2024

Conversation

iNerdStack
Copy link
Contributor

Description

This PR adds the detection logic for dynamic element found in conditional rendering and refactored previous implementation for detecting array for better cleaner logic & code structure.

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thank you for the refactor as well!

@Kitenite Kitenite merged commit 2d01986 into onlook-dev:main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants