Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Sanding #878

Merged
merged 14 commits into from
Dec 13, 2024
Merged

UI Sanding #878

merged 14 commits into from
Dec 13, 2024

Conversation

drfarrell
Copy link
Collaborator

Description

Improvements to...

  • Node tree – making it more obvious what elements belong to a component (purple text)
  • Project Settings page – better typography, glossy background, better close button, and better text labels
  • Project sub-menu dropdown – make this go away after the user has selected an item from the menu
  • Inputs – made the quad-icon not cut-off on the sides, tightened the spacing of the accordions

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@drfarrell
Copy link
Collaborator Author

I'm still going to work on this a bit – but just saving this here.

@drfarrell drfarrell requested a review from Kitenite December 12, 2024 17:47
Kitenite
Kitenite approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Kitenite Kitenite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge it if the one question is intentional

Kitenite
Kitenite requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, found a visual bug from the animation

Electron.mp4

@drfarrell drfarrell requested a review from Kitenite December 13, 2024 00:36
Kitenite
Kitenite reviewed Dec 13, 2024
View reviewed changes
apps/studio/src/routes/editor/LayersPanel/Tree/TreeNode.tsx
@@ -138,6 +138,16 @@ const TreeNode = observer(
node.data.isVisible = !node.data.isVisible;
}

function hasComponentAncestor(node: NodeApi<LayerNode>): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very expensive operation. With a large enough tree, the app will grind to a halt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Good thing too because I added some extra performance fix thanks to this.

@Kitenite Kitenite merged commit 963eec7 into main Dec 13, 2024
@Kitenite Kitenite deleted the ui-polish-1 branch December 13, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kitenite Kitenite Kitenite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drfarrell @Kitenite