Feat/window settings #880
Merged
Feat/window settings #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went through and cleaned up some of the UI, but great stuff! @Kitenite I'll leave it to you to hide the window feature until we build the functionality. |
Kitenite
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firstly, I wasn't sure where to store all the state variables for these settings so I stored them in the components itself, if needed we can move them somewhere else, which I'm guessing would be the case.
Second, I'm not able to apply the text-smallPlus class to the width and height input elements, if possible take a look at that.
#809
What is the purpose of this pull request?