Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resize handles to ClickRect component #909

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 18, 2024

Add resize handles to ClickRect component

This PR adds resize handles to the ClickRect component and fixes event handling issues:

Changes

  • Added visual resize handles to ClickRect component
  • Updated Overlay dimensions to enable proper event propagation
  • Maintained existing pointer event behavior while allowing resize handle interactions

Testing

  • Visual testing of resize handles appearance
  • Verified pointer events behavior
  • Confirmed proper event propagation through component hierarchy

Notes

  • Resize functionality will be implemented in a future PR
  • Focus on UI implementation and event handling fixes

Link to Devin run: https://app.devin.ai/sessions/09ff7bc9e5594fc1b6b0ffdd0fa93b0c

- Add ResizeHandles component for visual resize controls
- Add corner, edge, and radius handles
- Style handles to match design tool conventions
- Prepare for future drag functionality implementation

Co-Authored-By: Kiet <hoakiet98@gmail.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@Kitenite Kitenite merged commit 2d81b31 into main Dec 18, 2024
@Kitenite Kitenite deleted the devin/1734486183-add-resize-handles branch December 18, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant