Revert changes to LiftConstantsToInitializersPass #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
force-pushed
the
justinchu/revert-lift-pass
branch
from
355fbd0 to
7bd7104
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 81.80% 81.72% -0.08%
==========================================
Files 57 57
Lines 6968 6955 -13
Branches 953 947 -6
==========================================
- Hits 5700 5684 -16
- Misses 902 905 +3
Partials 366 366 ☔ View full report in Codecov by Sentry. |
titaiwangms
approved these changes
Jun 1, 2025
titaiwangms
pushed a commit
to titaiwangms/ir-py
that referenced
this pull request
Jun 2, 2025
Revert changes to LiftConstantsToInitializersPass because I realized even without variable shadowing, two subgraphs can still define initializers that have the same names in their respective naming scopes. A conflict resolution logic is still needed to ensure initializers coming from different subgraphs do not collide. So I reverted my changes. --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes to LiftConstantsToInitializersPass because I realized even without variable shadowing, two subgraphs can still define initializers that have the same names in their respective naming scopes. A conflict resolution logic is still needed to ensure initializers coming from different subgraphs to not collide. So I reverted my changes.