This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Fix shrink_mask in _prepare_StridedSlice for dynamic input shape #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
changed the title
wenbingl
reviewed
May 21, 2020
wenbingl
approved these changes
May 21, 2020
|
This pull request introduces 1 alert when merging 341cf7e into 40ccba8 - view on LGTM.com new alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice op supports negative begin and end, so we can use negative value rather than calculating input shape (not working for dynamic shape)