Support NHWC compute format in concat and conv's pad op. #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add NHWC support to
Concatoperator, andPadoperator created byConv.Original behaviour
Concat
Concat didn't support NHWC format, so tensors must be transposed back to NCHW before concat, and may be converted to NHWC to do other compuation.
Pad of Conv
When explicit padding is used in Conv, the pad was done before input tensor was transposed, which also leads to a pair of unresolvable
Transposeoperators.Changes
This MR added NHWC support to
concatoperator, and pad was done on transposed input of conv.