Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added apply_slice function to enable multiple versions of Slice #291

Merged
merged 2 commits into from
May 1, 2019
Merged

Added apply_slice function to enable multiple versions of Slice #291

merged 2 commits into from
May 1, 2019

Conversation

prabhat00155
Copy link
Collaborator

No description provided.

vinitra-zz
vinitra-zz approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@vinitra-zz vinitra-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor consistency suggestion included.

@prabhat00155 prabhat00155 merged commit 68843f0 into master May 1, 2019
@prasanthpul prasanthpul deleted the prroy/add_slice branch July 26, 2019 19:05
@prasanthpul prasanthpul restored the prroy/add_slice branch July 26, 2019 19:06
@prasanthpul prasanthpul deleted the prroy/add_slice branch July 26, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitra-zz vinitra-zz vinitra-zz approved these changes

@wenbingl wenbingl wenbingl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhat00155 @wenbingl @vinitra-zz