Fix conversion of XGBoost model after being restored - Cont #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadupre
reviewed
Nov 30, 2021
xadupre
approved these changes
Dec 1, 2021
|
license/cla shows |
BowenBao
force-pushed
the
bowbao/num_class
branch
from
062c76c
to
badb290
Compare
xadupre
approved these changes
Dec 6, 2021
BowenBao
force-pushed
the
bowbao/num_class
branch
3 times, most recently
from
8a8476b
to
5a88a73
Compare
Infer num_class and n_estimators through tree_info add target_opset to test cases Adjust opset version for hummingbird due to torch opset version support Signed-off-by: BowenBao <bowbao@microsoft.com>
BowenBao
force-pushed
the
bowbao/num_class
branch
from
5a88a73
to
47dc574
Compare
|
@xadupre CI all green, please merge when you get a chance, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #506.
After being restored, the loaded booster is not exactly the same in memory.
best_ntree_limitis not saved duringsave_model.This PR enables
num_classandn_estimatorsinference throughtree_infoinstead ofbest_ntree_limit.tree_infois a required property for gbtree JSON schema https://xgboost.readthedocs.io/en/latest/tutorials/saving_model.html?highlight=tree_info#json-schema.