Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discrepancies with XGBRegressor and xgboost > 2 #670

Merged
merged 9 commits into from
Dec 16, 2023
Merged

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Dec 11, 2023

No description provided.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
onnxmltools/convert/xgboost/_parse.py Fixed Show fixed Hide fixed
if objective == "binary:logistic":
if num_class is not None:
ncl = num_class
n_estimators = ntrees // ncl

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable n_estimators is not used.
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre merged commit 7858f9f into onnx:main Dec 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant