Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'Neg' nodes in TransposeOptimizer #1785

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

jan-haug
Copy link
Contributor

Neg nodes are also element-wise operations, so we can handle them like similar nodes, e.g. Abs (see #1699).

Signed-off-by: Jan Haug <jan@recogni.com>
@jan-haug jan-haug force-pushed the jan-haug/optimize-neg-transpose branch from 494faf0 to aba7620 Compare November 23, 2021 11:28
Copy link
Contributor

@hwangdeyu hwangdeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Any other comments? @fatcat-z

@hwangdeyu hwangdeyu merged commit 72d6460 into onnx:master Nov 28, 2021
@jan-haug jan-haug deleted the jan-haug/optimize-neg-transpose branch December 3, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants