-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keras Conv2D BiasAdd fuse #1796
Conversation
2ee097f
to
98f72d4
Compare
This pull request introduces 1 alert when merging 98f72d4 into 72d6460 - view on LGTM.com new alerts:
|
98f72d4
to
d070b6d
Compare
008217e
to
23b6712
Compare
Signed-off-by: hwangdeyu <dejack953@outlook.com>
Signed-off-by: hwangdeyu <dejack953@outlook.com>
Signed-off-by: hwangdeyu <dejack953@outlook.com>
Signed-off-by: hwangdeyu <dejack953@outlook.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: fatcat-z <jiz@microsoft.com>
Hi @guschmue, |
tf_optimize() sure will change the graph but should not change numerical results. We call it for every path (just not the one in this issue) - must be some problem how we call it in this case. |
Yeah, there may have been a misunderstanding in my comment before. I mean that after adding the optimize change code, some tests are failed in
But test_api.py #L65 L66 can be passed. So the onnx graph is ok and onnxruntime can be run successfully and get the same numerical results with original keras model. |
6aa6b5d
to
036a3ce
Compare
Signed-off-by: hwangdeyu <dejack953@outlook.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: fatcat-z <jiz@microsoft.com>
036a3ce
to
50ea318
Compare
Signed-off-by: hwangdeyu <dejack953@outlook.com>
fixes #1741.
Signed-off-by: hwangdeyu dejack953@outlook.com