Fix tfjs CI failure and add tfjs convert log #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwangdeyu <dejack953@outlook.com>
fatcat-z
reviewed
Dec 15, 2021
tests/backend_test_base.py
Outdated
| @@ -203,15 +203,18 @@ def convert_to_tfjs(self, graph_def_path, output_names): | |||
| try: | |||
| from tensorflowjs.converters import converter | |||
| except ImportError: | |||
| self.logger.debug("Tensorflowjs.converters package import failed.") | |||
There was a problem hiding this comment.
We need a warning for such case.
hwangdeyu
force-pushed
the
Fix_tfjs_CI
branch
from
b37a913 to
11d2bb0
Compare
Signed-off-by: hwangdeyu <dejack953@outlook.com>
hwangdeyu
force-pushed
the
Fix_tfjs_CI
branch
from
11d2bb0 to
236ef47
Compare
fatcat-z
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hwangdeyu dejack953@outlook.com