Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Windows image to windows-2019. #1879

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Upgrade Windows image to windows-2019. #1879

merged 2 commits into from
Mar 16, 2022

Conversation

fatcat-z
Copy link
Collaborator

@fatcat-z fatcat-z commented Mar 15, 2022 •
edited
Loading

  1. The current windows image is going to be retired so replace it with a latest one.
  2. Remove some unnecessary changes for recovering onnx-weekly CI job.
  3. List pip packages for some CI jobs.
  4. Python 3.6 is not supported by windows-2022, so upgrade to windows-2019.

Signed-off-by: Jay Zhang jiz@microsoft.com

@fatcat-z
Upgrade Windows image to windows-2022.
436196f 
Signed-off-by: Jay Zhang <jiz@microsoft.com>
hwangdeyu
hwangdeyu approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@hwangdeyu hwangdeyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.
Mark actions/runner-images#4312.

@fatcat-z
Use windows-2019 since the latest version of windows image doens't su…
75df225 
…pport Python 3.6.

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z fatcat-z changed the title Upgrade Windows image to windows-2022. Upgrade Windows image to windows-2019. Mar 16, 2022
@fatcat-z fatcat-z merged commit ee75f4a into onnx:main Mar 16, 2022
@fatcat-z fatcat-z deleted the upgrade_windows_image branch March 16, 2022 02:47
@fatcat-z fatcat-z mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangdeyu hwangdeyu hwangdeyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatcat-z @hwangdeyu