Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split transpose optimizer tests #1923

Merged
merged 4 commits into from
May 6, 2022

Conversation

hwangdeyu
Copy link
Contributor

Signed-off-by: Deyu Huang deyhuang@microsoft.com
Co-authored-by: Jay Zhang jiz@microsoft.com

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
@hwangdeyu hwangdeyu requested a review from fatcat-z April 25, 2022 13:44
@hwangdeyu hwangdeyu force-pushed the transpose_split_optimizer branch 3 times, most recently from 81c5d1e to c8abc8d Compare April 29, 2022 04:18
((1, -1), (1, 1710), (1710,), [1, 0]),
((3, 1, 1, 5, -1), (3, 1, 1, 5, 6), (3, 5, 6), [0, 2, 3, 4, 1]),
])
def test_transpose_with_split_dynamic_shape(self, input_shape, specific_input, output_shape, perm):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for #1809.

@hwangdeyu hwangdeyu force-pushed the transpose_split_optimizer branch from c8abc8d to 86d72dc Compare April 29, 2022 04:24
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@hwangdeyu hwangdeyu force-pushed the transpose_split_optimizer branch from 86d72dc to 3739c79 Compare April 29, 2022 06:15
tests/test_optimizers.py Outdated Show resolved Hide resolved
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hwangdeyu hwangdeyu merged commit c67bcfb into onnx:main May 6, 2022
@hwangdeyu hwangdeyu deleted the transpose_split_optimizer branch May 6, 2022 01:15
hwangdeyu added a commit to hwangdeyu/tensorflow-onnx that referenced this pull request May 6, 2022
* add split transpose optimizer tests

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>

* add dynamic split optimizer test

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* improve code quality

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>

Co-authored-by: Jay Zhang <jiz@microsoft.com>
hwangdeyu added a commit that referenced this pull request May 6, 2022
* add split transpose optimizer tests

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>

* add dynamic split optimizer test

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* improve code quality

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>

Co-authored-by: Jay Zhang <jiz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants