-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add split transpose optimizer tests #1923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com>
hwangdeyu
force-pushed
the
transpose_split_optimizer
branch
3 times, most recently
from
April 29, 2022 04:18
81c5d1e
to
c8abc8d
Compare
hwangdeyu
commented
Apr 29, 2022
((1, -1), (1, 1710), (1710,), [1, 0]), | ||
((3, 1, 1, 5, -1), (3, 1, 1, 5, 6), (3, 5, 6), [0, 2, 3, 4, 1]), | ||
]) | ||
def test_transpose_with_split_dynamic_shape(self, input_shape, specific_input, output_shape, perm): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test for #1809.
hwangdeyu
force-pushed
the
transpose_split_optimizer
branch
from
April 29, 2022 04:24
c8abc8d
to
86d72dc
Compare
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
hwangdeyu
force-pushed
the
transpose_split_optimizer
branch
from
April 29, 2022 06:15
86d72dc
to
3739c79
Compare
fatcat-z
reviewed
Apr 29, 2022
Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com>
fatcat-z
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
hwangdeyu
added a commit
to hwangdeyu/tensorflow-onnx
that referenced
this pull request
May 6, 2022
* add split transpose optimizer tests Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com> * add dynamic split optimizer test Signed-off-by: Deyu Huang <deyhuang@microsoft.com> * improve code quality Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com>
hwangdeyu
added a commit
that referenced
this pull request
May 6, 2022
* add split transpose optimizer tests Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com> * add dynamic split optimizer test Signed-off-by: Deyu Huang <deyhuang@microsoft.com> * improve code quality Signed-off-by: Deyu Huang <deyhuang@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com> Co-authored-by: Jay Zhang <jiz@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Deyu Huang deyhuang@microsoft.com
Co-authored-by: Jay Zhang jiz@microsoft.com