Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new api from_tflite to improve user experience. #1954

Merged
merged 3 commits into from
May 30, 2022
Merged

Add a new api from_tflite to improve user experience. #1954

merged 3 commits into from
May 30, 2022

Conversation

fatcat-z
Copy link
Collaborator

  1. Add a new api from_tflite() so users could call it to import a tflite model.
  2. Add relative test code as well.

Fix #1938

Signed-off-by: Jay Zhang jiz@microsoft.com

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z fatcat-z requested review from guschmue and hwangdeyu May 30, 2022 05:18
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Copy link
Contributor

@hwangdeyu hwangdeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the description of new api from_tflite in https://github.com/onnx/tensorflow-onnx#python-api-reference at the same time?

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z fatcat-z self-assigned this May 30, 2022
@fatcat-z
Copy link
Collaborator Author

Add the description of new api from_tflite in https://github.com/onnx/tensorflow-onnx#python-api-reference at the same time?

Good catch!

Copy link
Contributor

@hwangdeyu hwangdeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fatcat-z fatcat-z merged commit 16eb4b4 into onnx:main May 30, 2022
@fatcat-z fatcat-z deleted the add_from_tflite branch August 31, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: tf2onnx.convert.from_tflite
2 participants