Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on graph tf optimize grappler dependency #2020

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Turn on graph tf optimize grappler dependency #2020

merged 2 commits into from
Aug 12, 2022

Conversation

hwangdeyu
Copy link
Contributor

@hwangdeyu hwangdeyu commented Aug 5, 2022 •
edited
Loading

  • Fix lstm cell with activation and dropout settings issue in tf2.
  • Fix random_normal_rewriter output in test_random_std_normal backend test error once dependency enabled.

fixes #2002

@hwangdeyu hwangdeyu mentioned this pull request Aug 10, 2022
Closed
hwangdeyu and others added 2 commits August 10, 2022 18:40
@hwangdeyu
Turn on graph tf optimize grappler dependency
41b9296 
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
@hwangdeyu @fatcat-z
Aviod output name rewrite in random normal
a1f1d86 
Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
@hwangdeyu hwangdeyu force-pushed the optimize_dependency branch from be287e6 to a1f1d86 Compare August 10, 2022 10:42
@hwangdeyu hwangdeyu requested a review from fatcat-z August 10, 2022 10:43
fatcat-z
fatcat-z approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hwangdeyu hwangdeyu merged commit 4debef7 into onnx:main Aug 12, 2022
@hwangdeyu hwangdeyu deleted the optimize_dependency branch August 12, 2022 02:43
fatcat-z added a commit that referenced this pull request Sep 21, 2022
@hwangdeyu @fatcat-z
Turn on graph tf optimize grappler dependency (#2020)
bd79c6d 
* Turn on graph tf optimize grappler dependency

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>

* Aviod output name rewrite in random normal

Signed-off-by: Deyu Huang <deyhuang@microsoft.com>
Co-authored-by: Jay Zhang <jiz@microsoft.com>
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to convert LSTM cell with activation and dropout settings
2 participants
@hwangdeyu @fatcat-z