Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tf.strings.reduce_join mapping #2091

Merged
merged 13 commits into from
Mar 16, 2023
Merged

Adding tf.strings.reduce_join mapping #2091

merged 13 commits into from
Mar 16, 2023

Conversation

fsalv
Copy link
Contributor

@fsalv fsalv commented Dec 2, 2022

It only supports one reduce axis, as in onnxruntime_extensions StringJoin op.

@fsalv
Copy link
Contributor Author

fsalv commented Dec 5, 2022

Unit tests regarding tfjs are failing, but I didn't touched in any way related code. What could be a reason for that?

fatcat-z and others added 8 commits December 6, 2022 09:22
Signed-off-by: Jay Zhang <jiz@microsoft.com>

Signed-off-by: Jay Zhang <jiz@microsoft.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
* Add Support for MatMulInteger

MatMulInteger was supported in ONNX opset v10 (not checked in proposed change, the error can be addressed on save), this specific type combination is support in TensorFlow, but the node type not identified and handled properly here.

Handles onnx#2071

Signed-off-by: Gregory Morse <gregory.morse@live.com>

* Update math.py

Signed-off-by: Gregory Morse <gregory.morse@live.com>

* Update support_status.md

Signed-off-by: Gregory Morse <gregory.morse@live.com>

* Update test_backend.py

Signed-off-by: Gregory Morse <gregory.morse@live.com>

Signed-off-by: Gregory Morse <gregory.morse@live.com>
Co-authored-by: Jay Zhang <36183870+fatcat-z@users.noreply.github.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
* Upgrade CI pipelines to support latest TF and ONNX runtime.

Signed-off-by: Jay Zhang <jiz@microsoft.com>

* Upgrade CI pipelines to support latest TF and ONNX runtime.

Signed-off-by: Jay Zhang <jiz@microsoft.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contributions!

@fatcat-z fatcat-z merged commit 535f74c into onnx:main Mar 16, 2023
f-salvetti added a commit to f-salvetti/tensorflow-onnx that referenced this pull request Jul 4, 2023
- update current opset to 18
- added Cumprod (onnx#2133)
- added ReduceJoin (onnx#2091)

Signed-off-by: f-salvetti <fsalvetti@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants