-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tf.strings.reduce_join mapping #2091
Conversation
Unit tests regarding tfjs are failing, but I didn't touched in any way related code. What could be a reason for that? |
Signed-off-by: Jay Zhang <jiz@microsoft.com> Signed-off-by: Jay Zhang <jiz@microsoft.com> Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
* Add Support for MatMulInteger MatMulInteger was supported in ONNX opset v10 (not checked in proposed change, the error can be addressed on save), this specific type combination is support in TensorFlow, but the node type not identified and handled properly here. Handles onnx#2071 Signed-off-by: Gregory Morse <gregory.morse@live.com> * Update math.py Signed-off-by: Gregory Morse <gregory.morse@live.com> * Update support_status.md Signed-off-by: Gregory Morse <gregory.morse@live.com> * Update test_backend.py Signed-off-by: Gregory Morse <gregory.morse@live.com> Signed-off-by: Gregory Morse <gregory.morse@live.com> Co-authored-by: Jay Zhang <36183870+fatcat-z@users.noreply.github.com> Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
* Upgrade CI pipelines to support latest TF and ONNX runtime. Signed-off-by: Jay Zhang <jiz@microsoft.com> * Upgrade CI pipelines to support latest TF and ONNX runtime. Signed-off-by: Jay Zhang <jiz@microsoft.com> Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <Francesco.Salvetti@nuance.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contributions!
It only supports one reduce axis, as in onnxruntime_extensions StringJoin op.