Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent graph in loop "cond" subgraphs #2201

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

f-salvetti
Copy link
Contributor

@f-salvetti f-salvetti commented Jul 7, 2023

Fix #2200

@f-salvetti f-salvetti force-pushed the fix-While-loop branch 3 times, most recently from 98ac5a8 to 181982b Compare July 10, 2023 10:35
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
@f-salvetti f-salvetti marked this pull request as ready for review July 11, 2023 07:38
@@ -302,6 +302,23 @@ def func(i):
output_names_with_port = ["output:0"]
self.run_test_case(func, feed_dict, input_names_with_port, output_names_with_port, rtol=1e-06)

@check_tf_min_version("2")
@skip_tflite("shape inference fails with tflite")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open an issue to describe this and put the link here for a record?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created here: #2209

Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fatcat-z fatcat-z merged commit d0ba20e into onnx:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loop incorrectly handling "cond" subgraphs
2 participants