Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong shapes in loop body inputs if shape invariances are set in TF #2203

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Fix wrong shapes in loop body inputs if shape invariances are set in TF #2203

merged 4 commits into from
Jul 26, 2023

Conversation

f-salvetti
Copy link
Contributor

Fix #2202

@f-salvetti f-salvetti force-pushed the fix-loop-body-wrong-input-shapes branch from 7e03226 to c0f6f4b Compare July 10, 2023 11:21
@f-salvetti f-salvetti marked this pull request as ready for review July 10, 2023 15:43
@fatcat-z
Copy link
Collaborator

Thanks, this is a great catch!

Could you please add the case you mentioned in related issue as a test into test_cond.py file as well?

@f-salvetti
fix wrong shapes in loop body inputs if shape invariances are set in TF
c9ee19e 
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
@f-salvetti
fix and enable test for TF2
6858c4d 
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
@f-salvetti f-salvetti force-pushed the fix-loop-body-wrong-input-shapes branch from 399f66f to 6858c4d Compare July 24, 2023 10:24
@f-salvetti
skip tflite due to infinite loop
d27a102 
Signed-off-by: Salvetti, Francesco <francesco.salvetti@nuance.com>
@f-salvetti f-salvetti mentioned this pull request Jul 24, 2023
Closed
@f-salvetti
Copy link
Contributor Author

@fatcat-z I enabled for TF2 a test already present (after fixing it for TF2), however it is failing for tflite due to an infinite loop. I am creating an issue to track this: #2210

fatcat-z
fatcat-z approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@f-salvetti
Merge branch 'main' into fix-loop-body-wrong-input-shapes
37419db 
Signed-off-by: f-salvetti <francesco.salvetti@nuance.com>
@fatcat-z fatcat-z merged commit 6dda2bb into onnx:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

While loop wrong input shape with TF shape invariance
2 participants
@f-salvetti @fatcat-z