-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no attribute '_captures' issue for Tensorflow 2.13+ #2215
Conversation
Thank you very much for this PR! There are some pylint errors:
|
I have fixed the pylint warning, please refer to the latest commit. |
Thank you. There are still pylint errors about trailing whitespaces. Could you remove them all? |
Signed-off-by: Guoqing Bao <guoqing.bao@enflame-tech.com>
Signed-off-by: Guoqing Bao <guoqing.bao@enflame-tech.com>
Signed-off-by: Guoqing Bao <guoqing.bao@enflame-tech.com>
I have removed the trailing whitespace, could you help merge this request? |
Thank you for the update. I don't have the permission to merge pull requests in this repo. I noticed a maintainer imported changes here to a new pulll request #2216, so this pull request is probably in scope. |
Thanks for your contributions! This will be included in another PR which aims to support the latest version of TensorFlow. Please feel free to close this. |
I saw there is a PR that changed "_captures" to "captures" for the latest TensorFlow, but that will not be compatible with the lower version of TensorFlow, right? |
The code in #2216 supports lower versions of TensorFlow as well. The logic is almost as same as yours but your code checks "captures" while that code checks "_captures". |
That's great! I come out with this based on the earlier revision. |
This issue is related to #2172 and #2180