Fix unsupported ops TF 2.14.0: OnesLike #2270
Conversation
|
Thanks for your contributions! Yes, please add a test case as well. |
Signed-off-by: Alexander Gerstenberger <agerstenberger@apptek.com>
Signed-off-by: Alexander Gerstenberger <agerstenberger@apptek.com>
|
Added some test cases |
Signed-off-by: Alexander Gerstenberger <agerstenberger@apptek.com>
tests/test_backend.py
Outdated
| @@ -4105,6 +4105,54 @@ def func(x, y): | |||
| self._run_test_case(func, [_OUTPUT], {_INPUT: input_x.astype(np.int32), _INPUT1: input_y}, as_session=True, | |||
| graph_validator=lambda g: check_op_count(g, "ConstantOfShape", 1, disabled=False)) | |||
|
|
|||
| @check_tf_max_version("2.13.1") | |||
There was a problem hiding this comment.
This means this test case won't be run on any versions above 2.13.1. Could you please share why we can't do this? Or we can remove this limitation?
tests/test_backend.py
Outdated
| @@ -4105,6 +4105,54 @@ def func(x, y): | |||
| self._run_test_case(func, [_OUTPUT], {_INPUT: input_x.astype(np.int32), _INPUT1: input_y}, as_session=True, | |||
| graph_validator=lambda g: check_op_count(g, "ConstantOfShape", 1, disabled=False)) | |||
|
|
|||
| @check_tf_max_version("2.13.1") | |||
| @check_opset_min_version(9, "ConstantOfShape") | |||
| @check_opset_max_version(9, "ConstantOfShape") | |||
There was a problem hiding this comment.
Since we already have 2 functions for different versions, we don't need to add an opset limitation for these test methods. And we don't need to create different test cases for different versions.
You just need to create one test case for tf op OnesLike, and the test framework will help on testing different ops. At least, please remove the check_opset_max_version so we don't limit it running on higher opset version which supports ConstantOfShape.
tests/test_backend.py
Outdated
| self._run_test_case(func, [_OUTPUT], {_INPUT: input_x.astype(np.int32), _INPUT1: input_y}, as_session=True, | ||
| graph_validator=lambda g: check_op_count(g, "Expand", 1, disabled=False)) | ||
|
|
||
| @check_tf_min_version("2.14.0") |
There was a problem hiding this comment.
Why do we need to require 2.14.0 version to run this test case?
Signed-off-by: Alexander Gerstenberger <agerstenberger@apptek.com>
|
Hi, thanks for your comments. |
Fixes #2267
Do you want a test case for this?