Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if latest protobuf can pass CI. #2327

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/pylint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Pylint Workflow

on:
push:
branches:
- main

jobs:
pylint:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.8 # Specify the desired Python version (e.g., 3.8, 3.9)

- name: Install dependencies
run: pip install pylint==2.4.4

- name: Run pylint
run: |
pip freeze
pylint --rcfile=tools/pylintrc --ignore=version.py,tflite --disable=cyclic-import tf2onnx tests/*.py tools -j 0
displayName: 'Pylint'

# Add other jobs or steps as needed
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ steps:
conda config --set always_yes yes --set changeps1 no
pip install onnxconverter-common
pip install $(ONNX_PATH)
pip uninstall -y protobuf
pip install "protobuf~=3.20"
# pip uninstall -y protobuf
# pip install "protobuf~=3.20"
pip install h5py==3.7.0
pip install parameterized
pip install timeout-decorator
Expand Down Expand Up @@ -84,8 +84,8 @@ steps:
echo Test numpy installation... && python -c "import numpy"
pip install onnxconverter-common
pip install %ONNX_PATH%
pip uninstall -y protobuf
pip install "protobuf~=3.20"
# pip uninstall -y protobuf
# pip install "protobuf~=3.20"
pip install h5py==3.7.0
pip install parameterized
pip install timeout-decorator
Expand Down
8 changes: 4 additions & 4 deletions ci_build/azure_pipelines/templates/keras2onnx_unit_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ steps:
conda config --set always_yes yes --set changeps1 no
pip install onnxconverter-common
pip install $(ONNX_PATH)
pip uninstall -y protobuf
pip install "protobuf~=3.20"
# pip uninstall -y protobuf
# pip install "protobuf~=3.20"
pip install h5py==3.7.0
pip install parameterized
pip install timeout-decorator
Expand Down Expand Up @@ -67,8 +67,8 @@ steps:
echo Test numpy installation... && python -c "import numpy"
pip install onnxconverter-common
pip install %ONNX_PATH%
pip uninstall -y protobuf
pip install "protobuf~=3.20"
# pip uninstall -y protobuf
# pip install "protobuf~=3.20"
pip install h5py==3.7.0
pip install parameterized
pip install timeout-decorator
Expand Down
3 changes: 2 additions & 1 deletion ci_build/azure_pipelines/templates/setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ steps:
pip uninstall -y tensorflow
pip install $(CI_PIP_TF_NAME)
pip uninstall -y protobuf
pip install "protobuf~=3.20"
# pip install "protobuf~=3.20"
pip install protobuf

python setup.py install

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def run(self):
author='ONNX',
author_email='onnx-technical-discuss@lists.lfaidata.foundation',
url='https://github.com/onnx/tensorflow-onnx',
install_requires=['numpy>=1.14.1', 'onnx>=1.4.1', 'requests', 'six', 'flatbuffers>=1.12', 'protobuf~=3.20'],
install_requires=['numpy>=1.14.1', 'onnx>=1.4.1', 'requests', 'six', 'flatbuffers>=1.12', 'protobuf'],
classifiers=[
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Developers',
Expand Down