Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transpose + Pad handler, for Keras app MobilenetV2 model #907

Merged
merged 6 commits into from
May 5, 2020

Conversation

jignparm
Copy link
Contributor

@jignparm jignparm commented May 4, 2020

Fix pad handler to create a copy of input Const node before modifying padding values.

Const nodes may be shared with several other downstream ops, and if so, we cannot modify pad values in that node -- we should create a copy of the node first.

Copy link
Contributor

@guschmue guschmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you fix the test

@jignparm
Copy link
Contributor Author

jignparm commented May 5, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jignparm jignparm merged commit d3dd7f0 into onnx:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants