Enhance Transpose optimizer "Mul" handler #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # if multiplier is 1-D | ||
| if len(multiplier.shape) == 1: | ||
| if multiplier.shape[0] == 1: |
There was a problem hiding this comment.
Is it possible for "if..." at line 491 be merged to 486 like:
"if not multiplier.shape or multipier.shape == [1]"
Plus shall we have any UT for the enhancement?
There was a problem hiding this comment.
Updated unit test to see if 1D const tensors can be jumped over.
For the 'if' merging, it seems cleaner to separate handling of scalars and 1D tensors into 2 blocks (mostly for readability)
guschmue
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
Previously Tranpose_Mul handler could only handle constant multipliers of shape (1). Added support fo shape(N).