Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quantization_helpers from TKML #21

Closed
jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Closed

Remove quantization_helpers from TKML #21

jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #65
Assignees
@jeremyfowers
Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority
Milestone
Version 1.0

Comments

@jeremyfowers
Copy link
Collaborator

Issue

All code related to quantization_helpers is both untested and undocumented. Given that this feature is rarely used, it should be removed from TKML.

@ramkrishna2910 @jeremyfowers
@jeremyfowers jeremyfowers added cleanup Cleaning up old/unused code and tech debt p1 Medium priority labels Dec 1, 2023
@jeremyfowers jeremyfowers added this to the Version 1.0 milestone Dec 2, 2023
@jeremyfowers jeremyfowers mentioned this issue Dec 4, 2023
Merged
@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
@jeremyfowers jeremyfowers added the breaking API breaking change that should get extra testing in canary label Dec 4, 2023
@jeremyfowers jeremyfowers reopened this Dec 5, 2023
@jeremyfowers jeremyfowers mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyfowers jeremyfowers

Labels
breaking API breaking change that should get extra testing in canary cleanup Cleaning up old/unused code and tech debt p1 Medium priority
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

21-remove-quantization_helpers-from-tkml onnx/turnkeyml
Release v1.0.0 onnx/turnkeyml
1 participant
@jeremyfowers