Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated quantization tool #53

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

jeremyfowers
Copy link
Collaborator

Closes #21 by removing the quantization_samples argument and all associated code from build_model()

@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers force-pushed the 21-remove-quantization_helpers-from-tkml branch from 119ff4f to a6c7be7 Compare December 4, 2023 16:28
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers marked this pull request as ready for review December 4, 2023 16:49
@jeremyfowers jeremyfowers enabled auto-merge (squash) December 4, 2023 16:49
Copy link
Collaborator

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please just address the downcast comment before merging.

src/turnkeyml/build/export.py Show resolved Hide resolved
@jeremyfowers jeremyfowers merged commit c7f3238 into canary Dec 4, 2023
10 checks passed
@jeremyfowers jeremyfowers deleted the 21-remove-quantization_helpers-from-tkml branch December 4, 2023 21:54
jeremyfowers added a commit that referenced this pull request Dec 6, 2023
Remove the deprecated quantization tool

Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants