Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarking_status stat is ambiguous #39

Closed
jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #48 or #65
Closed

benchmarking_status stat is ambiguous #39

jeremyfowers opened this issue Dec 1, 2023 · 0 comments · Fixed by #48 or #65
Assignees
@jeremyfowers
Labels
breaking API breaking change that should get extra testing in canary bug Something isn't working p0 Top priority
Milestone
Version 1.0

Comments

@jeremyfowers
Copy link
Collaborator

The "benchmarking status" stat is ambiguous because it is the status for the entire turnkey benchmark command execution.

Status should actually be broken out by tool phases:

  • analysis_status
  • build_status
  • benchmark_status

That way if the tool gets killed, we know what phase it got killed in.
@jeremyfowers jeremyfowers added bug Something isn't working p0 Top priority labels Dec 1, 2023
@jeremyfowers jeremyfowers self-assigned this Dec 1, 2023
@jeremyfowers jeremyfowers linked a pull request Dec 1, 2023 that will close this issue
Refactor build_model() out of benchmark_model() #48
Merged
@jeremyfowers jeremyfowers added this to the Version 1.0 milestone Dec 2, 2023
This was referenced Dec 2, 2023
Closed
Merged
@jeremyfowers jeremyfowers added the breaking API breaking change that should get extra testing in canary label Dec 4, 2023
@jeremyfowers jeremyfowers reopened this Dec 5, 2023
@jeremyfowers jeremyfowers mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyfowers jeremyfowers

Labels
breaking API breaking change that should get extra testing in canary bug Something isn't working p0 Top priority
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Refactor build_model() out of benchmark_model() onnx/turnkeyml
Release v1.0.0 onnx/turnkeyml
1 participant
@jeremyfowers