-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build_model() out of benchmark_model() #48
Merged
jeremyfowers
merged 18 commits into
canary
from
39-benchmarking_status-stat-is-ambiguous
Dec 5, 2023
Merged
Refactor build_model() out of benchmark_model() #48
jeremyfowers
merged 18 commits into
canary
from
39-benchmarking_status-stat-is-ambiguous
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfowers
changed the title
39 benchmarking status stat is ambiguous
Refactor build_model() out of benchmark_model()
Dec 1, 2023
jeremyfowers
force-pushed
the
39-benchmarking_status-stat-is-ambiguous
branch
from
December 2, 2023 20:48
f51621e
to
ac186be
Compare
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
jeremyfowers
force-pushed
the
39-benchmarking_status-stat-is-ambiguous
branch
from
December 4, 2023 14:55
2d14e0e
to
5d95213
Compare
https://test.pypi.org/project/turnkeyml/0.4.0/ available for testing |
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
danielholanda
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on a few different scenarios.
Working as expected + reducing a ton of code.
Very happy!
…:onnx/turnkeyml into 39-benchmarking_status-stat-is-ambiguous
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
jeremyfowers
added a commit
that referenced
this pull request
Dec 6, 2023
* Refactor build out of benchmarking Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50 by eliminating the
benchmark_model()
APICloses #39 by collecting independent telemetry for builds and benchmarks
Closes #10 by creating the build marker on the proper line of code
Also fixes numerous documentation bugs that were referencing
benchmark_model()
when they should have been referencingbuild_model()
.Demo
Build Killed
(tkml) jfowers@LAPTOP-5VK03G46:~/turnkeyml/models/transformers$ turnkey bert.py --process-isolation --timeout 10 --rebuild always
Times out during torch export.
in stats:
build_status: running
. Before, it would have saidbenchmark_status: running
.Shows in
turnkey cache list
and gets properly deleted inturnkey cache delete --all
. Before, it would have been ignored.rebuild=never
After the killed build, run
turnkey bert.py --rebuild never
This will throw
Build intentionally skipped because rebuild=never
as expected.The stats say:
build_status: running
, which is the expected value (no mention ofbenchmark_status
). Before, it would have saidbenchmark_status: failed
which would have covered up the fact that the original build was killed.Benchmark killed
Run
turnkey bert.py --rebuild-always
and then ctrl+c it after the build finishes.In stats:
Before, it would have just said
benchmark_status: running
with no mention of build status.