Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional system_info #246

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Added additional system_info #246

merged 14 commits into from
Dec 20, 2024

Conversation

amd-pworfolk
Copy link
Contributor

Added collection of additional data for system_info, and updated method to collect Python package versions.

Closes #245

@amd-pworfolk
Added additional system_info
e415786 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Lint and formatting corrections
8eb9870 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
ramkrishna2910
ramkrishna2910 requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
src/turnkeyml/common/build.py Outdated Show resolved Hide resolved
@amd-pworfolk
Mapped wmic cmds to PowerShell Get-CimInstance cmdlets
645660c 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Fixed lint errors
952f772 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Integrated wmi module for accessing system information
ce06ffc 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Fixed lint errors
381de17 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Removed commented out code
87d29ab 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
amd-pworfolk
amd-pworfolk commented Dec 6, 2024
View reviewed changes
Copy link
Contributor Author

@amd-pworfolk amd-pworfolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by migrating from wmic to wmi package.

@amd-pworfolk
Copy link
Contributor Author

The new system_info code is now passing all the tests, including linux. If you have access to a linux box or WSL, would you please run the new file I created, src/turnkeyml/common/system_info.py, as a script and check that the output looks good on those platforms. Thanks!

amd-pworfolk and others added 4 commits December 9, 2024 22:13
@amd-pworfolk
Added system-info as a management tool
c7eaa61 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Fixed black formatting
71e65e0 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Merge branch 'main' into main
d2cf1d2
@amd-pworfolk
Merge branch 'main' into main
dd7d427 
Signed-off-by: Patrick Worfolk <166068376+amd-pworfolk@users.noreply.github.com>
@amd-pworfolk
Added documentation
63ac9a6 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@amd-pworfolk
Merge branch 'main' of https://github.com/amd-pworfolk/turnkeyml
9a27c80
@amd-pworfolk
Specified Python version
11168e5 
Signed-off-by: amd-pworfolk <patrick.worfolk@amd.com>
@ramkrishna2910 ramkrishna2910 merged commit 8b691e6 into onnx:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielholanda danielholanda danielholanda left review comments

@ramkrishna2910 ramkrishna2910 ramkrishna2910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture additional system info
3 participants
@amd-pworfolk @danielholanda @ramkrishna2910