Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop saving labels files in the cache #54

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Stop saving labels files in the cache #54

merged 4 commits into from
Dec 4, 2023

Conversation

jeremyfowers
Copy link
Collaborator

Closes #8

@jeremyfowers
Stop saving labels files in the cache
96fb51b 
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers linked an issue Dec 4, 2023 that may be closed by this pull request
Eliminate the cache/labels directory #8
Closed
@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
@jeremyfowers
Fix lint
e3d3b7e 
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers marked this pull request as ready for review December 4, 2023 17:51
@jeremyfowers jeremyfowers changed the base branch from main to canary December 4, 2023 18:59
@jeremyfowers
Keep an important if statement
bb65d00 
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
danielholanda
danielholanda approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All good here.

@jeremyfowers jeremyfowers merged commit d5390fb into canary Dec 4, 2023
10 checks passed
@jeremyfowers jeremyfowers deleted the 8-eliminate-the-cachelabels-directory branch December 4, 2023 22:25
jeremyfowers added a commit that referenced this pull request Dec 6, 2023
@jeremyfowers
Stop saving labels files in the cache (#54)
f25f1af 
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkrishna2910 ramkrishna2910 ramkrishna2910 approved these changes

@danielholanda danielholanda danielholanda approved these changes

Assignees

@jeremyfowers jeremyfowers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate the cache/labels directory
3 participants
@jeremyfowers @danielholanda @ramkrishna2910