-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Silicon Support (ORT and CoreML) #67
Conversation
def local_onnx_dir(self): | ||
return os.path.join(self.local_output_dir, self.onnx_dirname) | ||
def local_model_dir(self): | ||
return os.path.join(self.local_output_dir, self.model_dirname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This naming convention was modified as it was too restrictive. We certainly don't want all models going to onnx/model.onnx
if the output of the build process is not an onnx model.
Please note that this is not a breaking change according to our plugin contract, as the signature of BaseRT has not changed (apart from optional args added).
Description
This PR adds Apple Silicon support to ORT and creates a new runtime for CoreML.
PR was tested on MacOS v12.7.1 (21G920) on a MacBook M1.
Setup
I only tested this on my local machine, so I'm curious to understand how smooth the installation process is.
I got an
OSError
with Lightgbm, which was solved by runningconda install lightgbm
. Not sure if others will encounter the same.Testing
cd into the
timm
folder and runturnkey resnet18.py --device apple_silicon --runtime coreml
To do before merging this PR
apple_silicon
deviceFuture Work (Issues to be created)