Only add evaluation stats to the report once #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
jeremyfowers
force-pushed
the
81-multi-cache-reporting-has-a-quadratic-number-of-rows-in-the-csv
branch
from
5ce4f78 to
9a3c566
Compare
danielholanda
approved these changes
Jan 10, 2024
jeremyfowers
deleted the
81-multi-cache-reporting-has-a-quadratic-number-of-rows-in-the-csv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
all_evaluation_statsis a list that aggregates results across all caches, such that we can write them to the report CSV.The implementation has a bug where we were adding
all_evaluation_statstoreportin the loop that traverses the caches, meaning results from cache N of T would be written to the CSV T-N times. Which would make the report insanely large if you have many caches.