dianna package: eXplainable AI for ONNX models (XAI4ONNX) #291
Conversation
|
Indicating Ramakrishnan Sivakumar and Javier Martinez as reviewers as advised in the Slack thread. |
Added link to the dianna (XAI for ONNX models) overview tutorial. Signed-off-by: Elena Ranguelova <E.Ranguelova@esciencecenter.nl> Signed-off-by: elboyran <e.ranguelova@esciencecenter.nl>
…r ONNX models Signed-off-by: elboyran <e.ranguelova@esciencecenter.nl>
elboyran
force-pushed
the
xai4onnx_dianna
branch
from
e027a7c to
45c84d0
Compare
elboyran
changed the title
|
Looks good to me. Please wait for @javier-intel to approve as well. |
|
@ramkrishna2910 and @javier-intel thank you for the approval. |
|
I wonder if the urls should be improved? At least some checks fail. |
|
I will try to fix those. (All checks were passing when I first submitted the PR.) |
Signed-off-by: Ranguelova Elena <E.Ranguelova@esciencecenter.nl>
|
@andife, @ramkrishna2910, @javier-intel I see now the previously failing workflow is expecting approval. |
|
Hi @elboyran there still appear to be a couple of failures in the last log. Were this the same or are they new ones? |
Some are the same, but it's hard for me to judge which are considered insecure URLs. I removed some I thought they might be. Some URL checks still fail without pointing to specific ones. Shall I remove all then (they are pointing to data and papers to explainers)? Please, note that some checks fail not from my tutorial, but from the repo's README.md (which I modified only with a link to my tutorial). |
Signed-off-by: Ranguelova Elena <E.Ranguelova@esciencecenter.nl>
|
Hi @javier-intel , I have removed the links. If it fails again, I hope it is not due to my notebook. |
|
There are 3 issues flagged by the validation tool. Those are in the main branch and unrelated to your changes so they shouldn't block the PR. I'll merge the changes and fix the 404 flagged by the tool separately at a later time. |
|
[celebrate] Elena Ranguelova reacted to your message:
…________________________________
From: Javier Martinez ***@***.***>
Sent: Monday, July 15, 2024 1:13:11 PM
To: onnx/tutorials ***@***.***>
Cc: Elena Ranguelova ***@***.***>; Mention ***@***.***>
Subject: Re: [onnx/tutorials] dianna package: eXplainable AI for ONNX models (XAI4ONNX) (PR #291)
Merged #291<#291> into main.
—
Reply to this email directly, view it on GitHub<#291 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYYBWPRIIR4PNEJRK2YP6DZMPDGPAVCNFSM6AAAAABJVRF7FKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGUYDKNBRHEYDANI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Description
Motivation and Context