Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding one cell model file for NS xApp #1141

Merged
merged 4 commits into from
Feb 26, 2023
Merged

adding one cell model file for NS xApp #1141

merged 4 commits into from
Feb 26, 2023

Conversation

srashika
Copy link
Contributor

No description provided.

woojoong88
woojoong88 reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@woojoong88 woojoong88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however, please fix code to pass CI test.
The problem is the chart versions. You should bump up RAN-Simulator and sd-ran Helm charts' versions.

@woojoong88 woojoong88 merged commit 13f5c57 into onosproject:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woojoong88 woojoong88 woojoong88 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srashika @woojoong88