Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onos-o1t helm chart #121

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Add onos-o1t helm chart #121

merged 5 commits into from
Oct 23, 2020

Conversation

adibrastegarnia
Copy link
Contributor

Add onos-o1t helm chart.

@adibrastegarnia adibrastegarnia requested review from ray-milkey and removed request for kuujo October 21, 2020 23:53
kuujo
kuujo reviewed Oct 22, 2020
View reviewed changes
onos-o1t/templates/deployment.yaml Outdated
serviceAccountName: onos-o1t
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the new template and values for setting the Docker registry here. Look at the onos-ric chart.

kuujo
kuujo requested changes Oct 22, 2020
View reviewed changes
onos-o1t/values.yaml Show resolved Hide resolved
@kuujo
Copy link
Contributor

kuujo commented Oct 22, 2020

I think we actually need to bootstrap this chart and the e2t chart and all other terminations using StatefulSet with a headless Service as is done in the onos-ric chart. This will be necessary for clients (xApps) to be able to talk to specific replicas.

@kuujo
Copy link
Contributor

kuujo commented Oct 22, 2020 •
edited
Loading

Maybe we can get away with a Deployment plus headless service for the termination. I have to try to remember the reason I had to use a StatefulSet in onos-ric.

@kuujo
Copy link
Contributor

kuujo commented Oct 22, 2020

Yeah @adibrastegarnia I think we should stick with a Deployment for now and add a headless service. This would be more ideal since it can be scaled more easily. If we have trouble coordinating within the service we can change to a StatefulSet later.

@adibrastegarnia
Copy link
Contributor Author

adibrastegarnia commented Oct 22, 2020 •
edited
Loading

@kuujo
Please take a look and see if I addressed your comments?

kuujo
kuujo requested changes Oct 22, 2020
View reviewed changes
onos-o1t/templates/_helpers.tpl Outdated
{{/*
onos-o1t image name
*/}}
{{- define "onos-o1t.image-name" -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using imagename rather than image-name for consistency with the naming of other helpers and the helpers in other charts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

onos-o1t/templates/service.yaml Show resolved Hide resolved
@adibrastegarnia adibrastegarnia merged commit 5b70a42 into onosproject:master Oct 23, 2020
@adibrastegarnia adibrastegarnia deleted the add_onos_o1t_helm branch October 23, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuujo kuujo kuujo approved these changes

@ray-milkey ray-milkey Awaiting requested review from ray-milkey

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adibrastegarnia @kuujo