Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KPIMON chart - add toJson for config.json #464

Merged
merged 1 commit into from
May 18, 2021
Merged

Update KPIMON chart - add toJson for config.json #464

merged 1 commit into from
May 18, 2021

Conversation

woojoong88
Copy link
Contributor

No description provided.

@woojoong88 woojoong88 self-assigned this May 18, 2021
@@ -42,6 +42,10 @@ config:
kpimon:
e2tEndpoint: "onos-e2t:5150"
kpmVersion: "v2"
config_json:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update the yang model already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This JSON should be generated based on the yang model if you want to use onos-config to update the values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update the yang model already?

Not yet - will do it sooner. However, still it requires setting the granularity period at the initial stage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you need to make sure the models are match otherwise the onos-config cannot be used for setting values because the schema is different. I think it affects report_period as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but you need to make sure the models are match otherwise the onos-config cannot be used for setting values because the schema is different. I think it affects report_period as well.

Yeah ok. I think when I work on the yang model for period configuration in runtime, I will check this out. At this moment, I think this PR is good enough.

@woojoong88 woojoong88 merged commit c556164 into onosproject:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants