Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated yang models to make enterprise and other fields manda… #670

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Updated yang models to make enterprise and other fields manda… #670

merged 1 commit into from
Jul 9, 2021

Conversation

jamesk1997
Copy link
Contributor

…tory

SeanCondon
SeanCondon reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@SeanCondon SeanCondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in all of these YANG files - the id key should be changed from string to inet:yang-identifier, to prevent crap being entered for an ID through the API

@SeanCondon
Copy link
Contributor

you should also be increasing the version to 3.0.6 in Chart.yaml

@jamesk1997 jamesk1997 force-pushed the jkUpdateYang1 branch 3 times, most recently from 226bc4f to df7fe15 Compare July 9, 2021 12:30
SeanCondon
SeanCondon approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@SeanCondon SeanCondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One last thing, while you're here - I think you can change the mtu minimum value to 68 - i think this is already the case for ip-domain in the GUI, but here it seems to be 0

@SeanCondon SeanCondon merged commit 8d470a2 into onosproject:master Jul 9, 2021
@SeanCondon SeanCondon deleted the jkUpdateYang1 branch July 9, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanCondon SeanCondon SeanCondon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesk1997 @SeanCondon