sdcore-adapter chart initial checkin #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCondon
approved these changes
Sep 18, 2020
| @@ -0,0 +1,29 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
generally it's only through the umbrella chart that I load the configs as a post install job.
The theory is that if you're just loading this chart individually you're probably a developer and do not want a sample config loaded automatically every time
There was a problem hiding this comment.
deferring for now, will discuss.
| @@ -0,0 +1,2 @@ | |||
| { | |||
There was a problem hiding this comment.
I think you could leave out the whole configs folder, and have them only in the aether-umbrella chart
|
|
||
| image: | ||
| repository: onosproject/sdcore-adapter | ||
| tag: v0.1.0 |
There was a problem hiding this comment.
I don't think this release is in Docker Hub yet?
change dns name in certs; eliminate insecure mode; use args instead of env; run command directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires related patch in sdcore-adapter