Fail when pending tests pass

[gaffo]

Would it be possible to run pending specs and only fail them when they pass? This was a nice feature of cucumber once upon a time basically saying "hey this now works" and trying to keep the number of pending specs small.

[williammartin]

@gaffo Could you elaborate on this a little, I'm not sure I fully understand the feature. What is the UX you forsee?

[gaffo]

Mainly just that if you were to make your own custom Before/After... which I'm doing to run certain sets of befores in certain test modes.... the errors show up correctly to the line of test not to the Before shim. Does that make sense?

…

On Mon, Dec 4, 2017 at 1:28 PM, William Martin ***@***.***> wrote: @gaffo <https://github.com/gaffo> Could you elaborate on this a little, I'm not sure I fully understand the feature. What is the UX you forsee? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#374 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvLEBhgSPP8FN3ORCgEUBhnohaqN_Gks5s9GP_gaJpZM4PNj0c> .

[williammartin]

No sorry, are you describing your other open issue #377 ?

[gaffo]

Oh duh... Sorry

…

On Dec 4, 2017 14:29, "William Martin" ***@***.***> wrote: No sorry, are you describing your other open issue #377 <#377> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#374 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvLLhKSjxrJe-Lpu3kO7LJJOabwIpSks5s9HJYgaJpZM4PNj0c> .

[gaffo]

So basically in some other test frameworks you can run in a special mode where you say "if a pending spec passes, it should fail" this way you see the test failures as specs that should be running every time. Eg, these are specs that are accidentally off. It's a tool that helps with cleanup. I used it with cucumber before and it basically would fail the build if we had specs that should have been enabled but were not.

Does that make sense?

[williammartin]

Oh yeh that's definitely an interesting feature. Do you happen to have a link to the Cucumber feature, maybe we could follow the same UX?

[onsi]

I'm working through the backlog of old Ginkgo issues - apologies as this issue is probably stale now.

I think --failOnPending was introduced after this issue? And I think it solves this use case?

I'm going to close this for now, but feel free to reopen it if you'd like.